Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QUICHE from b6e4ee8a1 to 12228ccfc #18753

Merged

Conversation

RenjieTang
Copy link
Contributor

@RenjieTang RenjieTang commented Oct 25, 2021

https://github.com/google/quiche/compare/b6e4ee8a1..12228ccfc

$ git log b6e4ee8a1..12228ccfc --date=short --no-merges --format="%ad %al %s"

2021-10-25 renjietang Allow QuicSentPacketManager to expose the setter of num_ptos_for_path_degrading_.
2021-10-25 ianswett Move the QUICHE_EXPORT_PRIVATE after class and const InvalidHeaderSet to fix merge.
2021-10-25 ianswett Modify the B207 connection option subtract 2 packets from the queueing threshold instead of adding 2 in STARTUP. Now exits STARTUP after 1 round of no bandwidth growth, as intended.
2021-10-25 wub Deprecate --gfe2_reloadable_flag_quic_restore_connection_context_in_alarms.
2021-10-25 ianswett Put QUICHE_EXPORT_PRIVATE before strut in quiche_text_utils.h to fix merge.
2021-10-21 haoyuewang Add QuicTlsLoasClient(Server)Stream that can complete LOAS-TLS handshake.
2021-10-21 ianswett Refactor QUIC Bbr2's CheckBandwidthGrowth() into HasBandwidthGrowth() so when the excess queue criteria is used, we can stay in STARTUP if there was bandwidth growth that round.
2021-10-21 wub Group some client hello information into ParsedClientHello, a new struct that can be passed around easily.
2021-10-21 fayang Deprecate gfe2_reloadable_flag_quic_add_upperbound_for_queued_packets.
2021-10-20 rch Do not call OnCanCreateNewOutgoingStream() from QuicSession::StreamDraining for IETF QUIC versions. Only receiving a MAX_STREAMS frame can allow a new stream to be created.
2021-10-20 wub Fix an undefined behavior in QuicChaosProtector::AddPingFrames when remaining_padding_bytes_ is zero after split.
2021-10-20 bnc Add QpackDecoderStreamReceiver fuzzer.
2021-10-20 bnc Add QpackDecoderStreamSender fuzzer.
2021-10-20 bnc Remove QPACK fuzz corpora.
2021-10-20 bnc Exercise Flush() in QpackEncoderStreamSender fuzzer.
2021-10-20 fayang Logging more info when ConsumeCryptoData fails.
2021-10-20 wub Miscellaneous test changes for IETF QUIC mTLS support: - Make gfe2::test::SetClientCert work for IETF QUIC client. - Make gfe2::test::SimpleQuicClient::connection_error const. - Change ClientCertRequestsTest.TestClientCertsHeadersStripped to verify the value of GFE_SSL_CERTIFICATE is replaced by GFE, rather than verifying the value is of a specific value.
2021-10-20 bnc Add print_elements_test.cc.
2021-10-19 bnc Remove QuicFuzzedDataProvider.
2021-10-19 fayang Deprecate gfe2_reloadable_flag_quic_add_missing_update_ack_timeout.
2021-10-19 fayang In QUIC, accept empty CRYPTO frames.
2021-10-19 wub For mTLS, change QuicCryptoClientConfig to include a quic::ClientProofSource instead of a quic::ProofSource. Also set the cert and key in quic::TlsClientHandshaker's constructor, both will be used if server requests it.
2021-10-19 ianswett Refactor CheckExcessInflight to accept a second parameter and use it during PROBE_UP as well.
2021-10-19 quiche-dev Adds a missing include to http2_constants.h.
2021-10-18 danzh Refactor out http2::InvalidHeaderSet to share with QUIC. No behavior change.
2021-10-18 ianswett Adds the B207 connection option which causes QUIC BBR2 to exit STARTUP if bytes in flight doesn't go below 2*BDP at any point in the last round.

Signed-off-by: Renjie Tang [email protected]

Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

https://github.com/google/quiche/compare/b6e4ee8a1..12228ccfc

$ git log b6e4ee8a1..12228ccfc --date=short --no-merges --format="%ad %al %s"

2021-10-25 renjietang Allow QuicSentPacketManager to expose the setter of num_ptos_for_path_degrading_.
2021-10-25 ianswett Move the QUICHE_EXPORT_PRIVATE after class and const InvalidHeaderSet to fix merge.
2021-10-25 ianswett Modify the B207 connection option subtract 2 packets from the queueing threshold instead of adding 2 in STARTUP.  Now exits STARTUP after 1 round of no bandwidth growth, as intended.
2021-10-25 wub Deprecate --gfe2_reloadable_flag_quic_restore_connection_context_in_alarms.
2021-10-25 ianswett Put QUICHE_EXPORT_PRIVATE before strut in quiche_text_utils.h to fix merge.
2021-10-21 haoyuewang Add QuicTlsLoasClient(Server)Stream that can complete LOAS-TLS handshake.
2021-10-21 ianswett Refactor QUIC Bbr2's CheckBandwidthGrowth() into HasBandwidthGrowth() so when the excess queue criteria is used, we can stay in STARTUP if there was bandwidth growth that round.
2021-10-21 wub Group some client hello information into ParsedClientHello, a new struct that can be passed around easily.
2021-10-21 fayang Deprecate gfe2_reloadable_flag_quic_add_upperbound_for_queued_packets.
2021-10-20 rch Do not call OnCanCreateNewOutgoingStream() from QuicSession::StreamDraining for IETF QUIC versions. Only receiving a MAX_STREAMS frame can allow a new stream to be created.
2021-10-20 wub Fix an undefined behavior in QuicChaosProtector::AddPingFrames when remaining_padding_bytes_ is zero after split.
2021-10-20 bnc Add QpackDecoderStreamReceiver fuzzer.
2021-10-20 bnc Add QpackDecoderStreamSender fuzzer.
2021-10-20 bnc Remove QPACK fuzz corpora.
2021-10-20 bnc Exercise Flush() in QpackEncoderStreamSender fuzzer.
2021-10-20 fayang Logging more info when ConsumeCryptoData fails.
2021-10-20 wub Miscellaneous test changes for IETF QUIC mTLS support: - Make gfe2::test::SetClientCert work for IETF QUIC client. - Make gfe2::test::SimpleQuicClient::connection_error const. - Change ClientCertRequestsTest.TestClientCertsHeadersStripped to verify the value of GFE_SSL_CERTIFICATE is replaced by GFE, rather than verifying the value is of a specific value.
2021-10-20 bnc Add print_elements_test.cc.
2021-10-19 bnc Remove QuicFuzzedDataProvider.
2021-10-19 fayang Deprecate gfe2_reloadable_flag_quic_add_missing_update_ack_timeout.
2021-10-19 fayang In QUIC, accept empty CRYPTO frames.
2021-10-19 wub For mTLS, change QuicCryptoClientConfig to include a quic::ClientProofSource instead of a quic::ProofSource. Also set the cert and key in quic::TlsClientHandshaker's constructor, both will be used if server requests it.
2021-10-19 ianswett Refactor CheckExcessInflight to accept a second parameter and use it during PROBE_UP as well.
2021-10-19 quiche-dev Adds a missing include to http2_constants.h.
2021-10-18 danzh Refactor out http2::InvalidHeaderSet to share with QUIC. No behavior change.
2021-10-18 ianswett Adds the B207 connection option which causes QUIC BBR2 to exit STARTUP if bytes in flight doesn't go below 2*BDP at any point in the last round.

Signed-off-by: Renjie Tang <[email protected]>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #18753 was opened by RenjieTang.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 25, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18753 was opened by RenjieTang.

see: more, trace.

Signed-off-by: Renjie Tang <[email protected]>
@RenjieTang RenjieTang marked this pull request as ready for review October 25, 2021 20:54
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch self-assigned this Oct 25, 2021
@htuch
Copy link
Member

htuch commented Oct 25, 2021

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 25, 2021
@RenjieTang
Copy link
Contributor Author

/assign @RyanTheOptimist

@RyanTheOptimist RyanTheOptimist merged commit 45d8cd3 into envoyproxy:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants